Fix none bump type semantics and add hook-aware bumpy check#53
Merged
Conversation
- `none` no longer suppresses cascading bumps — it just skips the direct bump while allowing dependency propagation to still apply normally - `bumpy check` now detects untracked/staged bump files so it works before committing - New `--hook pre-commit` / `--hook pre-push` flag controls which bump files count based on git status - Output annotates bump files with their git status (staged, untracked)
|
The changes in this PR will be included in the next version bump.
|
Empty bump files no longer short-circuit — they act as a fallback covering uncovered packages in non-strict mode, while strict mode still requires per-package acknowledgment.
- `bumpy add --none` creates a bump file with all changed packages set to `none` — convenient for --strict mode - Empty bump files no longer bypass --strict mode - Updated docs and bump file
theoephraim
force-pushed
the
fix/none-semantics-and-check-hooks
branch
from
8f274e3 to
519e938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonebump type no longer suppresses cascading bumps — it now just skips the direct bump, while allowing dependency propagation to still apply normally. This makesnoneuseful for acknowledging internal changes (tests, config) that don't need a release on their own, without blocking cascades.bumpy checknow detects untracked/staged bump files — fixes the chicken-and-egg problem where bump files created but not yet committed weren't detected.--hook pre-commit/--hook pre-pushflag — controls which bump files count based on git status. Output annotates bump files with their status (staged, untracked).Test plan
noneallowing cascades,nonewith no cascade, andnonewith out-of-range cascadenone, verifybumpy checkpasses--hook pre-pushwarns about uncommitted bump files